pitrou commented on a change in pull request #8205:
URL: https://github.com/apache/arrow/pull/8205#discussion_r492005479
##########
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##########
@@ -89,5 +89,25 @@ inline void atomic_store(
*p = r;
}
+template <class T>
+inline bool atomic_compare_exchange_strong(
Review comment:
All other functions are explicitly marked inline in this file, but I can
make the change.
##########
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##########
@@ -89,5 +89,25 @@ inline void atomic_store(
*p = r;
}
+template <class T>
+inline bool atomic_compare_exchange_strong(
Review comment:
All other functions are explicitly marked inline in this file, but I can
make the change if desired.
##########
File path: cpp/src/arrow/type_traits.h
##########
@@ -22,7 +22,7 @@
#include <type_traits>
#include <vector>
-#include "arrow/type_fwd.h"
+#include "arrow/type.h"
Review comment:
Yes, there are errors such as:
```
../src/arrow/type_traits.h:149:1: error: incomplete type 'arrow::UInt8Type'
named in nested name specifier
PRIMITIVE_TYPE_TRAITS_DEF(uint8_t, UInt8, uint8)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/type_traits.h:145:14: note: expanded from macro
'PRIMITIVE_TYPE_TRAITS_DEF'
CType, ARROW_CONCAT(ArrowShort, Type), ARROW_CONCAT(ArrowShort,
Array), \
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/arrow/util/macros.h:24:28: note: expanded from macro 'ARROW_CONCAT'
#define ARROW_CONCAT(x, y) x##y
^
<scratch space>:126:1: note: expanded from here
UInt8Type
^
../src/arrow/type_traits.h:130:19: note: expanded from macro
'PRIMITIVE_TYPE_TRAITS_DEF_'
using CType = ArrowType_::c_type;
\
^~~~~~~~~~~~
../src/arrow/type_fwd.h:186:1: note: forward declaration of
'arrow::UInt8Type'
_NUMERIC_TYPE_DECL(UInt8)
^
../src/arrow/type_fwd.h:176:9: note: expanded from macro '_NUMERIC_TYPE_DECL'
class KLASS##Type; \
^
<scratch space>:274:1: note: expanded from here
UInt8Type
^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
