tustvold commented on code in PR #2109:
URL: https://github.com/apache/arrow-rs/pull/2109#discussion_r924962191


##########
parquet/src/column/writer/encoder.rs:
##########
@@ -77,6 +81,9 @@ pub trait ColumnValueEncoder {
     /// Write the corresponding values to this [`ColumnValueEncoder`]
     fn write(&mut self, values: &Self::Values, offset: usize, len: usize) -> 
Result<()>;
 
+    /// Write the corresponding values to this [`ColumnValueEncoder`]
+    fn write_gather(&mut self, values: &Self::Values, indices: &[usize]) -> 
Result<()>;

Review Comment:
   I'm not totally sold on this name, suggestions welcome



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to