tustvold commented on PR #2109:
URL: https://github.com/apache/arrow-rs/pull/2109#issuecomment-1189577742
Interestingly the performance gain is extremely minor, this might suggest
the bottleneck is elsewhere :thinking:
```
write_batch primitive/4096 values primitive
time: [1.8651 ms 1.8660 ms 1.8670 ms]
thrpt: [94.492 MiB/s 94.544 MiB/s 94.587 MiB/s]
change:
time: [-3.4958% -3.4494% -3.4001%] (p = 0.00 <
0.05)
thrpt: [+3.5198% +3.5727% +3.6224%]
Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
5 (5.00%) low mild
5 (5.00%) high mild
6 (6.00%) high severe
Benchmarking write_batch primitive/4096 values primitive non-null: Warming
up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 8.1s, enable flat sampling, or reduce sample count to 50.
write_batch primitive/4096 values primitive non-null
time: [1.6058 ms 1.6061 ms 1.6064 ms]
thrpt: [107.69 MiB/s 107.71 MiB/s 107.73 MiB/s]
change:
time: [-4.8854% -4.8376% -4.7946%] (p = 0.00 <
0.05)
thrpt: [+5.0361% +5.0836% +5.1363%]
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild
write_batch primitive/4096 values bool
time: [108.44 us 108.48 us 108.52 us]
thrpt: [10.476 MiB/s 10.479 MiB/s 10.483 MiB/s]
change:
time: [-3.5762% -3.4930% -3.3425%] (p = 0.00 <
0.05)
thrpt: [+3.4581% +3.6195% +3.7089%]
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low mild
3 (3.00%) high mild
4 (4.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
