drin commented on PR #13487: URL: https://github.com/apache/arrow/pull/13487#issuecomment-1189656685
Thanks @pitrou , I'll start with that as a base and add benchmarks that use the utilities from key_hash.h (I'll see if these also exist elsewhere). I recently was exposed to `hashing.h` when looking at the `count_distinct` function, so I should be able to compare them. Maybe I'll skeleton another compute function, `StandardHash` (arbitrary, temporary name to distinguish from `FastHash`), and we can use it to better consider how many hash functions we should have vs what should be knobs available via an `Options` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
