drin commented on PR #13487: URL: https://github.com/apache/arrow/pull/13487#issuecomment-1190754294
> Biggest feedback is to not allocate a large temporary `std::vector` and instead write directly into the buffer you'll be returning. Also you made your TempVectorStack way too big. thanks! I had troubles with smaller sizes and tried to not size it too large, but I'll revisit. For writing directly into the buffer to return, I assume that means I need to create an ArrayData? is there a better interface via Builders? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
