lidavidm commented on code in PR #13614:
URL: https://github.com/apache/arrow/pull/13614#discussion_r926204218
##########
java/dataset/src/main/cpp/CMakeLists.txt:
##########
@@ -63,3 +63,5 @@ add_arrow_test(dataset_jni_test
jni_util.cc
EXTRA_INCLUDES
${JNI_INCLUDE_DIRS})
+
+install(FILES jni_util.h DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/jni/dataset")
Review Comment:
Oh, hmm. Indeed, we originally had it under
`cpp/src/jni/dataset/jni_util.h`. On the other hand if I peek at a Conda
package it's not there (presumably because we don't enable JNI). Perhaps we
should make the breaking change and revert this so that downstream packages
cannot depend on this accidentally?
@jinchengchenghh, what is the use case for depending on `jni_util.h`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
