lidavidm commented on code in PR #13614:
URL: https://github.com/apache/arrow/pull/13614#discussion_r926204606


##########
java/dataset/src/main/cpp/CMakeLists.txt:
##########
@@ -63,3 +63,5 @@ add_arrow_test(dataset_jni_test
                jni_util.cc
                EXTRA_INCLUDES
                ${JNI_INCLUDE_DIRS})
+
+install(FILES jni_util.h DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/jni/dataset")

Review Comment:
   Ok from what I see above, there are some Arrow utilities that are being 
used. IMO, they should get vendored into the downstream project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to