AlenkaF commented on code in PR #13311:
URL: https://github.com/apache/arrow/pull/13311#discussion_r926243308
##########
python/setup.py:
##########
@@ -354,6 +468,19 @@ def append_cmake_bool(value, varname):
shutil.move(pjoin(build_prefix, 'include'),
pjoin(build_lib, 'pyarrow'))
+ # We need to, again, add the PyArrow cpp include folder
Review Comment:
It is because of these lines right before:
https://github.com/apache/arrow/blob/66cd4f9dffb067deed9af0bdb805e99d68acbcc0/python/setup.py#L464-L469
where the whole include folder is deleted in case of re-build. As the
pyarrow cpp includes are added in the previous step (`_run_cmake_pyarrow_cpp`)
they always get deleted. But are also needed when the `_run_cmake` starts.
Will add some more info to the comment +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
