AlenkaF commented on code in PR #13311:
URL: https://github.com/apache/arrow/pull/13311#discussion_r926292425
##########
python/setup.py:
##########
@@ -354,6 +468,19 @@ def append_cmake_bool(value, varname):
shutil.move(pjoin(build_prefix, 'include'),
pjoin(build_lib, 'pyarrow'))
+ # We need to, again, add the PyArrow cpp include folder
+ build_pyarrow_cpp_include = pjoin(
+ saved_cwd, 'build/dist/include')
+ if not os.path.isdir(
+ pjoin(build_pyarrow_cpp_include, "arrow", "python")):
+ self.mkpath(
Review Comment:
Hope I understood correctly, the changes I made (together with updated
comment from https://github.com/apache/arrow/pull/13311#discussion_r926243308):
```python
- # We need to, again, add the PyArrow cpp include folder
+ # As the pyarrow/include file has been deleted in the
previous step
+ # we need to, again, add the PyArrow cpp include folder also
build_pyarrow_cpp_include = pjoin(
saved_cwd, 'build/dist/include')
- if not os.path.isdir(
- pjoin(build_pyarrow_cpp_include, "arrow",
"python")):
- self.mkpath(
- pjoin(build_pyarrow_cpp_include, "arrow", "python"))
shutil.move(pjoin(
build_pyarrow_cpp_include, "arrow", "python"),
pjoin(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
