dragosmg commented on code in PR #13541:
URL: https://github.com/apache/arrow/pull/13541#discussion_r926285523
##########
r/src/compute-exec.cpp:
##########
@@ -125,6 +125,46 @@ std::shared_ptr<arrow::Schema> ExecNode_output_schema(
return node->output_schema();
}
+// [[arrow::export]]
+std::string ExecPlan_ToString(const std::shared_ptr<compute::ExecPlan>& plan) {
+ return plan->ToString();
+}
+
+// [[arrow::export]]
+std::string ExecPlan_ToStringWithSink(
+ const std::shared_ptr<compute::ExecPlan>& plan,
+ const std::shared_ptr<compute::ExecNode>& final_node, cpp11::list
sort_options,
+ int64_t head = -1) {
Review Comment:
Your proposed solution looks very similar to my approach in
https://github.com/apache/arrow/pull/13541/commits/f40e5d289553543ce070ac67bbcf565b289548b3.
The part I was missing (and was hoping to avoid) was to start producing the
plan. I don't know enough about the ExecPlan, but does `plan->StartProducing()`
have performance costs? Do we effectively have to choose between duplicating
code and running an unnecessary operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
