dragosmg commented on code in PR #13541:
URL: https://github.com/apache/arrow/pull/13541#discussion_r926635264
##########
r/src/compute-exec.cpp:
##########
@@ -125,6 +125,46 @@ std::shared_ptr<arrow::Schema> ExecNode_output_schema(
return node->output_schema();
}
+// [[arrow::export]]
+std::string ExecPlan_ToString(const std::shared_ptr<compute::ExecPlan>& plan) {
+ return plan->ToString();
+}
+
+// [[arrow::export]]
+std::string ExecPlan_ToStringWithSink(
+ const std::shared_ptr<compute::ExecPlan>& plan,
+ const std::shared_ptr<compute::ExecNode>& final_node, cpp11::list
sort_options,
+ int64_t head = -1) {
Review Comment:
I don't have formed thoughts on the cost of the tradeoff, but definitely the
variant with `ExecPlan_prepare` looks cleaner and avoids the _double
accounting_.
On the [CI
failure](https://github.com/apache/arrow/runs/7445803518?check_suite_focus=true#step:7:26180):
I don't think it has anything to do with this PR since it seems present in
most PR and was probably introduced in the last couple of days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
