rok commented on code in PR #13506:
URL: https://github.com/apache/arrow/pull/13506#discussion_r928528243
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -2638,14 +2694,18 @@ test_that("build_formats() and
build_format_from_order()", {
)
)
- # ab not supported yet
- expect_error(
- build_formats("abd"),
- '"abd" `orders` not supported in Arrow'
+ expect_equal(
+ build_format_from_order("abp"),
+ c("%a", "%b","%p", "%a", "%b", "%p")
+ )
+
+ expect_equal(
+ build_format_from_order("uYM"),
+ c("%y-%M", "%Y-%M", "%y%M", "%Y%M")
Review Comment:
These are odd. My suspicion is something is not quite right here:
https://github.com/apache/arrow/pull/13506/files#diff-8fdef8da9950901a3c1535c97b0370aad5a4fced647e29c76c22bc6114cf4880R222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
