rok commented on code in PR #13506:
URL: https://github.com/apache/arrow/pull/13506#discussion_r930221417
##########
r/R/dplyr-datetime-helpers.R:
##########
@@ -166,6 +166,18 @@ build_formats <- function(orders) {
orders <- gsub("[^A-Za-z]", "", orders)
orders <- gsub("Y", "y", orders)
+ invalid_orders <- nchar(gsub("[ymdqIHMS]", "", orders)) > 0
Review Comment:
I've made this into a different check. Basically the format needs to be
longer than 6 chars to be considered valid (e.g.: "ymd" -> "%Y%m%d" is 6 chars
long and is probably the shortest format we have).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
