tustvold commented on code in PR #2195:
URL: https://github.com/apache/arrow-rs/pull/2195#discussion_r931569201
##########
object_store/src/local.rs:
##########
@@ -990,8 +1015,6 @@ mod tests {
}
#[tokio::test]
- #[cfg(target_os = "linux")]
- // macos has some magic in its root '/.VolumeIcon.icns"' which causes this
test to fail
Review Comment:
This was actually a red-herring, mac os doesn't always have this file. In
particular in CI. I think it would be great if we could have an explicit test
of a broken link so that we have some test coverage of this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
