tustvold commented on code in PR #2195:
URL: https://github.com/apache/arrow-rs/pull/2195#discussion_r931628387
##########
object_store/src/local.rs:
##########
@@ -990,8 +1015,6 @@ mod tests {
}
#[tokio::test]
- #[cfg(target_os = "linux")]
- // macos has some magic in its root '/.VolumeIcon.icns"' which causes this
test to fail
Review Comment:
Fantastic, I had understood that this couldn't be relied on, that's good
that we can see the issue and get coverage of it in CI.
However, I still think an explicit symlink test would be worthwhile,
especially as I would not be surprised if Windows does something exciting,
etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
