westonpace commented on PR #13709:
URL: https://github.com/apache/arrow/pull/13709#issuecomment-1199853722
> I store the value in CsvFragmentScanOptions, and then restore it.
> How do you feel about this?
I like this approach if you can get it working. Can you add this to the
`CsvFileFormat` constructor?
```
else :
# default_fragment_scan_options is needed to add a transcoder
self.default_fragment_scan_options = CsvFragmentScanOptions()
if read_options is not None:
self.default_fragment_scan_options.encoding =
read_options.encoding
```
> Is it an option to add encoding as a field to the C struct ReadOptions?
That seems undesirable. The C++ csv reader doesn't have the field because
it has no ability to handle encodings. So I'm not sure we want to add a field
that is completely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
