kou commented on code in PR #13769: URL: https://github.com/apache/arrow/pull/13769#discussion_r934920983
########## r/tools/autobrew: ########## @@ -36,6 +43,13 @@ curl -fsSL https://github.com/$UPSTREAM_ORG/brew/tarball/master | tar xz --strip export HOMEBREW_CACHE="$AUTOBREW" LOCAL_FORMULA="tools/${PKG_BREW_NAME}.rb" if [ -f "$LOCAL_FORMULA" ]; then + if [[ ${OSTYPE:6} -ge 20 ]]; then + $BREW tap + + # Tap https://github.com/autobrew/homebrew-cran so that we can get dependencies from there + $BREW tap autobrew/cran Review Comment: Could you indent this part? ########## dev/tasks/homebrew-formulae/apache-arrow.rb: ########## @@ -34,13 +34,13 @@ class ApacheArrow < Formula license "Apache-2.0" head "https://github.com/apache/arrow.git"; - depends_on "boost" => :build - depends_on "cmake" => :build - depends_on "llvm" => :build depends_on "aws-sdk-cpp" + depends_on "boost" => :build depends_on "brotli" + depends_on "cmake" => :build depends_on "glog" depends_on "grpc" + depends_on "llvm" => :build Review Comment: Did you sort these `depends_on` manually? The original order is correct because Homebrew uses `depends_on` with `:build` -> `depends_on` without `:build` order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
