nealrichardson commented on code in PR #13769: URL: https://github.com/apache/arrow/pull/13769#discussion_r935558754
########## dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb: ########## @@ -0,0 +1,101 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# https://github.com/autobrew/homebrew-cran/blob/master/Formula/apache-arrow.rb Review Comment: Probably should say more than just this url: cloned from x, be sure to upstream changes to x, etc. Also you may want to edit the entry in the LICENSE.txt about the autobrew files to mention this one too. ########## r/tools/autobrew: ########## @@ -19,8 +19,15 @@ export HOMEBREW_NO_ANALYTICS=1 export HOMEBREW_NO_AUTO_UPDATE=1 -# Official Homebrew no longer supports El-Capitan -UPSTREAM_ORG="autobrew" +if [[ ${OSTYPE:6} -ge 20 ]]; then + # We are on a modern enough macOS, we can use the real brew + UPSTREAM_ORG="homebrew" + PKG_BREW_NAME="$PKG_BREW_NAME-static" +else + # Official Homebrew no longer supports El-Capitan + # so We need to use the forked autobrew version of brew that supports old macOSes Review Comment: ```suggestion # so we need to use the forked autobrew version of brew that supports old macOSes ``` ########## dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb: ########## @@ -86,7 +87,8 @@ def install return 0; } EOS - system ENV.cxx, "test.cpp", "-std=c++11", "-I#{include}", "-L#{lib}", "-larrow", "-o", "test" + system ENV.cxx, "test.cpp", "-std=c++11", "-I#{include}", "-L#{lib}", \ Review Comment: FTR I don't think we ever call `brew test` on what this produces ########## dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb: ########## @@ -0,0 +1,101 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# https://github.com/autobrew/homebrew-cran/blob/master/Formula/apache-arrow.rb + +class ApacheArrowStatic < Formula + desc "Columnar in-memory analytics layer designed to accelerate big data" + homepage "https://arrow.apache.org/"; + url "https://www.apache.org/dyn/closer.lua?path=arrow/arrow-8.0.0.9000/apache-arrow-8.0.0.9000.tar.gz"; + # Uncomment and update to test on a release candidate + # mirror "https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-8.0.0-rc1/apache-arrow-8.0.0.tar.gz"; + sha256 "9948ddb6d4798b51552d0dca3252dd6e3a7d0f9702714fc6f5a1b59397ce1d28" + head "https://github.com/apache/arrow.git"; + + bottle do Review Comment: are these required? We don't build these bottles do we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
