stuartcarnie commented on code in PR #2251:
URL: https://github.com/apache/arrow-rs/pull/2251#discussion_r934942068
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -1584,6 +1625,303 @@ fn cast_string_to_date64<Offset: OffsetSizeTrait>(
Ok(Arc::new(array) as ArrayRef)
}
+fn seconds_since_midnight(time: &chrono::NaiveTime) -> i32 {
+ let sec = time.num_seconds_from_midnight();
+ let frac = time.nanosecond();
+ let adjust = if frac < 1_000_000_000 { 0 } else { 1 };
+ (sec + adjust) as i32
+}
+
+fn milliseconds_since_midnight(time: &chrono::NaiveTime) -> i32 {
+ /// The number of nanoseconds per millisecond.
+ const NANOS_PER_MILLI: u32 = 1_000_000;
+ /// The number of milliseconds per second.
+ const MILLIS_PER_SEC: u32 = 1_000;
+
+ let sec = time.num_seconds_from_midnight() * MILLIS_PER_SEC;
+ let frac = time.nanosecond();
+ let (frac, adjust) = if frac < 1_000_000_000 {
+ (frac, 0)
+ } else {
+ (frac - 1_000_000_000, MILLIS_PER_SEC)
+ };
+ (sec + adjust + frac / NANOS_PER_MILLI) as i32
Review Comment:
Yes indeed, I concluded the same thing and pushed up the changes, thanks! I
will move the functions back inline as I originally had them, before I
overcomplicated it 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
