alamb commented on code in PR #2251:
URL: https://github.com/apache/arrow-rs/pull/2251#discussion_r935482492
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -2854,6 +3172,102 @@ mod tests {
}
}
+ #[test]
+ fn test_cast_string_to_time32second() {
+ let a1 = Arc::new(StringArray::from(vec![
+ Some("08:08:35.091323414"),
+ Some("08:08:60.091323414"), // leap second
+ Some("08:08:61.091323414"), // not valid
+ Some("Not a valid time"),
+ None,
+ ])) as ArrayRef;
+ let a2 = Arc::new(LargeStringArray::from(vec![
+ Some("08:08:35.091323414"),
+ Some("08:08:60.091323414"), // leap second
+ Some("08:08:61.091323414"), // not valid
+ Some("Not a valid time"),
+ None,
+ ])) as ArrayRef;
+ for array in &[a1, a2] {
+ let b = cast(array, &DataType::Time32(TimeUnit::Second)).unwrap();
+ let c = b.as_any().downcast_ref::<Time32SecondArray>().unwrap();
+ assert_eq!(29315, c.value(0));
+ assert_eq!(29340, c.value(1));
+ assert!(c.is_null(2));
+ assert!(c.is_null(3));
+ assert!(c.is_null(4));
+ }
+ }
+
+ #[test]
+ fn test_cast_string_to_time32millisecond() {
+ let a1 = Arc::new(StringArray::from(vec![
+ Some("08:08:35.091323414"),
+ Some("08:08:60.091323414"), // leap second
+ Some("08:08:61.091323414"), // not valid
+ Some("Not a valid time"),
+ None,
+ ])) as ArrayRef;
+ let a2 = Arc::new(LargeStringArray::from(vec![
+ Some("08:08:35.091323414"),
+ Some("08:08:60.091323414"), // leap second
Review Comment:
💯 for the leap second
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -2854,6 +3172,102 @@ mod tests {
}
}
+ #[test]
+ fn test_cast_string_to_time32second() {
Review Comment:
👍 these are great tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
