alamb opened a new pull request, #2284: URL: https://github.com/apache/arrow-rs/pull/2284
Draft until https://github.com/apache/arrow-rs/pull/2283 is merged # Which issue does this PR close? Closes #. # Rationale for this change Here are some cleanups I thought of while reviewing https://github.com/apache/arrow-rs/pull/2251 and I didn't want to hold the PR any longer (also I want an excuse to improve the temporal code in general). Once I did I found the same pattern had been copy/pasted in several places in the cast kernels so I fixed all uses up. Initially I suggested a bad pattern, but I found one that did working. I think this makes the code easier to read, and it should improve performance by removing bounds checks (and unecessary `String` construction and allocation) # What changes are included in this PR? Use `Iterator`s rather than `value()` and `is_null` and remove several `to_string()` calls # Are there any user-facing changes? No (maybe faster cast kernels) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
