HaoYang670 commented on PR #2284:
URL: https://github.com/apache/arrow-rs/pull/2284#issuecomment-1203385054
As the title says, there should be performance improvement. However, I don't
see it when doing benchmarks on my laptop:
Tested on Intel Ubuntu
```
cargo bench --bench cast_kernels -- --baseline master
```
```
...
cast utf8 to date32 512 time: [22.682 us 22.698 us 22.716 us]
change: [-0.3103% -0.2050% -0.1135%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
4 (4.00%) high mild
8 (8.00%) high severe
cast utf8 to date64 512 time: [39.237 us 39.258 us 39.285 us]
change: [+2.0238% +2.2611% +2.4840%] (p = 0.00 <
0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low mild
3 (3.00%) high mild
9 (9.00%) high severe
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
