tustvold commented on code in PR #2237:
URL: https://github.com/apache/arrow-rs/pull/2237#discussion_r935850997
##########
parquet/src/arrow/array_reader/complex_object_array.rs:
##########
@@ -43,6 +43,9 @@ where
column_desc: ColumnDescPtr,
column_reader: Option<ColumnReaderImpl<T>>,
converter: C,
+ need_consume_def_levels_buffer: Option<Vec<i16>>,
Review Comment:
I'd call this something like `in_progress_def_levels`
##########
parquet/src/arrow/array_reader/complex_object_array.rs:
##########
@@ -206,11 +213,19 @@ where
}
fn get_def_levels(&self) -> Option<&[i16]> {
- self.def_levels_buffer.as_deref()
+ if self.before_consume {
Review Comment:
I think this can just return `self.def_levels_buffer.as_deref()`, if you
look at PrimitiveArrayReader it will only make the data available after the
call to `consume_batch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
