Ted-Jiang commented on code in PR #2237:
URL: https://github.com/apache/arrow-rs/pull/2237#discussion_r936190661
##########
parquet/src/arrow/array_reader/complex_object_array.rs:
##########
@@ -206,11 +213,19 @@ where
}
fn get_def_levels(&self) -> Option<&[i16]> {
- self.def_levels_buffer.as_deref()
+ if self.before_consume {
Review Comment:
without this, will fail in
```
failures:
arrow::array_reader::complex_object_array::tests::test_complex_array_reader_def_and_rep_levels
arrow::array_reader::complex_object_array::tests::test_complex_array_reader_dict_enc_string
```
this cause by `get_level` before consume `complex_object_array` (this is
the common situation like other readers), but `complex_object_array`
sometimes(self is nullable) need `get_level` after consume, so i think we
should keep this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
