thisisnic commented on code in PR #13786:
URL: https://github.com/apache/arrow/pull/13786#discussion_r936124019


##########
r/tests/testthat/test-dplyr-mutate.R:
##########
@@ -279,16 +279,16 @@ test_that("dplyr::mutate's examples", {
   # Examples we don't support should succeed
   # but warn that they're pulling data into R to do so
 
-  # across and autosplicing: ARROW-11699
   compare_dplyr_binding(
     .input %>%
       select(name, homeworld, species) %>%
       mutate(across(!name, as.factor)) %>%
       collect(),
     starwars,
-    warning = "Expression across.*not supported in Arrow"
   )

Review Comment:
   This test now fails with the following error:
   
   ```
   Error in `collect()`:
   ! Invalid: ExecuteScalarExpression cannot Execute non-scalar expression 
dictionary_encode(homeworld, {null_encoding_behavior=MASK})
   /home/nic2/arrow/cpp/src/arrow/compute/exec/project_node.cc:91  
ExecuteScalarExpression(simplified_expr, target, plan()->exec_context())
   /home/nic2/arrow/cpp/src/arrow/compute/exec/exec_plan.cc:559  
iterator_.Next()
   /home/nic2/arrow/cpp/src/arrow/record_batch.cc:337  ReadNext(&batch)
   /home/nic2/arrow/cpp/src/arrow/record_batch.cc:351  ToRecordBatches()
   Run `rlang::last_error()` to see where the error occurred.
   ```
   TODO: investigate more, open JIRA, wrap test in expect_error with comment 
linking to JIRA



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to