nealrichardson commented on code in PR #13786: URL: https://github.com/apache/arrow/pull/13786#discussion_r936160255
########## r/tests/testthat/test-dplyr-mutate.R: ########## @@ -279,16 +279,16 @@ test_that("dplyr::mutate's examples", { # Examples we don't support should succeed # but warn that they're pulling data into R to do so - # across and autosplicing: ARROW-11699 compare_dplyr_binding( .input %>% select(name, homeworld, species) %>% mutate(across(!name, as.factor)) %>% collect(), starwars, - warning = "Expression across.*not supported in Arrow" ) Review Comment: Though we should probably make sure that `as.factor` isn't mapped to anything in the dplyr funcs for now, so that this fails in the right way rather than try to collect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org