GPSnoopy commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r492743655
##########
File path: cpp/src/arrow/util/compression.h
##########
@@ -30,7 +30,18 @@ namespace arrow {
struct Compression {
/// \brief Compression algorithm
- enum type { UNCOMPRESSED, SNAPPY, GZIP, BROTLI, ZSTD, LZ4, LZ4_FRAME, LZO,
BZ2 };
+ enum type {
Review comment:
Yes. You're correct. I double checked when I saw this PR and our code is
currently wrong. I'll probably add a few static asserts to make sure we catch
it in the future.
However, this would still in turn break our .NET ABI compatibility. The
proper fix on our side would be to completely abstract the enum values and
translate them both ways. Which is why I'd favour explicit enum values in
Arrow, as I think it's relatively cheap and would make our life much easier 😁
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
