tustvold commented on code in PR #2360:
URL: https://github.com/apache/arrow-rs/pull/2360#discussion_r940096750
##########
arrow/src/array/array_decimal.rs:
##########
@@ -336,6 +336,31 @@ impl BasicDecimalArray<Decimal128, Decimal128Array> for
Decimal128Array {
}
Ok(())
}
+
+ fn validate_decimal_with_bytes(&self, precision: usize) -> Result<()> {
Review Comment:
Unless I'm missing something, the performance benefit from this is derived
from the additional work being performed by the iterator. In particular
`BasicDecimal::new`. Perhaps we should fix this, as this will have benefits all
over the codebase? For one thing `BasicDecimal` could easily take a slice with
a known size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
