alamb commented on PR #2360: URL: https://github.com/apache/arrow-rs/pull/2360#issuecomment-1208611061
Hi @liukun4515 -- I don't fully understand this approach for validating Decimal values though I have not studied it as carefully as I would like to. Most other arrays have two paths: 1. Create from known good data (used in Builders where each individual value was validated individually) -- `ArrayData::new_unchecked` typically 2. Create from an array of arbitrary user input and then do a vectorized validation (ArrayData::validate) Since this PR seems to do something else a bit different I need to think about it some more, but I don't think I'll have time until later this week or this weekend to do so (I got caught up in https://github.com/apache/arrow-rs/pull/2369 for longer than I expected and now I am behind in some other areas) It sounds like @tustvold has some thoughts about the "big picture" of Decimal in general so perhaps that will help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
