tustvold commented on code in PR #2374:
URL: https://github.com/apache/arrow-rs/pull/2374#discussion_r940483326
##########
object_store/src/azure.rs:
##########
@@ -615,7 +628,7 @@ impl MicrosoftAzureBuilder {
self
}
- /// Set the Azure Access Key (required)
+ /// Set the Azure Access Key (required - one of token_credential ot access
key)
Review Comment:
```suggestion
/// Set the Azure Access Key (required - one of token_credential or
access key)
```
##########
object_store/src/azure.rs:
##########
@@ -627,6 +640,15 @@ impl MicrosoftAzureBuilder {
self
}
+ /// Set a TokenCredential to be used for authentication (required - one of
token_credential ot access key)
Review Comment:
```suggestion
/// Set a TokenCredential to be used for authentication (required - one
of token_credential or access key)
```
##########
object_store/src/azure.rs:
##########
@@ -627,6 +640,15 @@ impl MicrosoftAzureBuilder {
self
}
+ /// Set a TokenCredential to be used for authentication (required - one of
token_credential ot access key)
+ pub fn with_token_credential(
+ mut self,
+ token_credential: Arc<dyn TokenCredential>,
Review Comment:
Is there some way we could avoid leaking the azure_core type into the public
interface, this will not only make it easier to use, but also survive a move
away from the SDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
