roeap commented on code in PR #2374:
URL: https://github.com/apache/arrow-rs/pull/2374#discussion_r940489188
##########
object_store/src/azure.rs:
##########
@@ -627,6 +640,15 @@ impl MicrosoftAzureBuilder {
self
}
+ /// Set a TokenCredential to be used for authentication (required - one of
token_credential ot access key)
+ pub fn with_token_credential(
+ mut self,
+ token_credential: Arc<dyn TokenCredential>,
Review Comment:
I haven't looked at the S§ implementation, but I seem to remember, that we
do have some sense of a token credential as well. The problem I found with
that, is that "get_token" accepts a client, while by now the client is somewhat
hidden in the azure client. Also for gcs that was not a trait. Maybe thats the
way to go?
An alternative might be to expose all (some) options required to initialize
the token credentials. I guess we would always need that information regardless
of the underlying implementation ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
