tustvold commented on code in PR #3051:
URL: https://github.com/apache/arrow-datafusion/pull/3051#discussion_r941276733
##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -390,6 +452,50 @@ impl AsyncFileReader for ParquetFileReader {
}
}
+impl ParquetFileReaderFactory for DefaultParquetFileReaderFactory {
+ fn create_reader(
+ &self,
+ partition_index: usize,
+ file_meta: FileMeta,
+ metadata_size_hint: Option<usize>,
+ metrics: &ExecutionPlanMetricsSet,
+ ) -> Result<Box<dyn AsyncFileReader + Send>> {
+ let parquet_file_metrics = ParquetFileMetrics::new(
+ partition_index,
+ file_meta.location().as_ref(),
+ metrics,
+ );
+
+ Ok(Box::new(ParquetFileReader {
+ meta: file_meta.object_meta,
+ store: Arc::clone(&self.store),
+ metadata_size_hint,
+ metrics: parquet_file_metrics,
+ }))
+ }
+}
+
+///
+/// BoxedAsyncFileReader has been created to satisfy type requirements of
+/// parquet stream builder constructor.
Review Comment:
https://github.com/apache/arrow-rs/pull/2368 is the one that will remove the
need for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
