alamb commented on PR #3051: URL: https://github.com/apache/arrow-datafusion/pull/3051#issuecomment-1209438154
> I have added test that checks whether data access ops are routed to parquet file reader factory, is it sufficient ? The only other thing I would suggest is making it a "cargo integration test" by putting it in `datafusion/core/tests/custom_parquet_reader.rs` or something. The reason is that by being in `datafusion/core/src/datasource/file_format/parquet.rs` will allow it access to crate local things (so for example, the test will not catch if the necessary traits are accidentally not publicly exposed, which has happened when we have moved code around in the past 🤦 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
