toddfarmer commented on code in PR #13815:
URL: https://github.com/apache/arrow/pull/13815#discussion_r941561745
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -445,7 +446,7 @@ private long computeAndCheckOffsetsBufferSize(int
valueCount) {
* an additional slot in offset buffer.
*/
final long size = computeCombinedBufferSize(valueCount + 1, OFFSET_WIDTH);
- if (size > MAX_ALLOCATION_SIZE) {
+ if (size > MAX_BUFFER_SIZE) {
throw new OversizedAllocationException("Memory required for vector
capacity " +
valueCount +
" is (" + size + "), which is more than max allowed (" +
MAX_ALLOCATION_SIZE + ")");
Review Comment:
I wonder whether the exception messages should point users to
LargeVar*Vectors when exceeding buffer capacity. Based on my experiences with
RDBMS, I expected LargeVarCharVector to be suitable for storing large values,
and missed that it is needed for many small values as well. I'm not sure how
well-understood this is, and perhaps users would benefit from being pointed in
an appropriate direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
