lwhite1 commented on code in PR #13815:
URL: https://github.com/apache/arrow/pull/13815#discussion_r941585589
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -430,7 +431,7 @@ public void allocateNew(int valueCount) {
/* Check if the data buffer size is within bounds. */
private void checkDataBufferSize(long size) {
- if (size > MAX_ALLOCATION_SIZE || size < 0) {
+ if (size > MAX_BUFFER_SIZE || size < 0) {
Review Comment:
Nit: I assume the check for negative size values is for overflows, but even
so, the appearance of a negative in the error message text below could be
misleading as a literal reading would say that a negative number is more than
the max allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
