tustvold commented on code in PR #2435:
URL: https://github.com/apache/arrow-rs/pull/2435#discussion_r944579956


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -109,27 +233,29 @@ impl ArrowReaderOptions {
         }
     }
 
-    /// Scan rows from the parquet file according to the provided `selection`
+    /// Set this true to enable decoding of the [PageIndex] if present. This 
can be used
+    /// to push down predicates to the parquet scan, potentially eliminating 
unnecessary IO
     ///
-    /// TODO: Revisit this API, as [`Self`] is provided before the file 
metadata is available
-    #[allow(unused)]
-    pub(crate) fn with_row_selection(self, selection: impl Into<RowSelection>) 
-> Self {

Review Comment:
   This API is removed, as it was impossible to use



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to