tustvold commented on code in PR #2435:
URL: https://github.com/apache/arrow-rs/pull/2435#discussion_r944580751
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -427,46 +606,36 @@ mod tests {
};
use crate::errors::Result;
use crate::file::properties::{EnabledStatistics, WriterProperties,
WriterVersion};
- use crate::file::reader::{FileReader, SerializedFileReader};
use crate::file::writer::SerializedFileWriter;
use crate::schema::parser::parse_message_type;
use crate::schema::types::{Type, TypePtr};
use crate::util::test_common::rand_gen::RandGen;
#[test]
fn test_arrow_reader_all_columns() {
- let parquet_file_reader =
- get_test_reader("parquet/generated_simple_numerics/blogs.parquet");
+ let file =
get_test_file("parquet/generated_simple_numerics/blogs.parquet");
- let mut arrow_reader =
ParquetFileArrowReader::new(parquet_file_reader);
-
- let record_batch_reader = arrow_reader
- .get_record_reader(60)
- .expect("Failed to read into array!");
+ let builder = ParquetRecordBatchReaderBuilder::try_new(file).unwrap();
+ let original_schema = Arc::clone(&builder.schema());
+ let reader = builder.build().unwrap();
// Verify that the schema was correctly parsed
- let original_schema =
arrow_reader.get_schema().unwrap().fields().clone();
- assert_eq!(original_schema, *record_batch_reader.schema().fields());
+ assert_eq!(original_schema.fields(), reader.schema().fields());
Review Comment:
I'm not really sure this test makes sense anymore, but I kept the spirit of
it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
