tustvold commented on code in PR #2435:
URL: https://github.com/apache/arrow-rs/pull/2435#discussion_r945730452
##########
parquet/src/arrow/schema.rs:
##########
@@ -1662,14 +1662,9 @@ mod tests {
writer.close()?;
// read file back
- let mut arrow_reader = ParquetFileArrowReader::try_new(file).unwrap();
- let read_schema = arrow_reader.get_schema()?;
- assert_eq!(schema, read_schema);
-
- // read all fields by columns
Review Comment:
There is no separate get_schema_by_columns API anymore, and there is no
difference between specifying ProjectionMask::all and not specifying a mask, so
this additional bit of the test no longer makes sense. It was added from when
get_schema_by_columns used completely different logic from the array reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
