tustvold commented on code in PR #2477:
URL: https://github.com/apache/arrow-rs/pull/2477#discussion_r947777483
##########
arrow/src/array/iterator.rs:
##########
@@ -104,69 +105,14 @@ pub type GenericStringIter<'a, T> = ArrayIter<&'a
GenericStringArray<T>>;
pub type GenericBinaryIter<'a, T> = ArrayIter<&'a GenericBinaryArray<T>>;
pub type GenericListArrayIter<'a, O> = ArrayIter<&'a GenericListArray<O>>;
-pub type BasicDecimalIter<'a, const BYTE_WIDTH: usize> =
- ArrayIter<&'a BasicDecimalArray<BYTE_WIDTH>>;
+pub type DecimalIter<'a, T> = ArrayIter<&'a DecimalArray<T>>;
/// an iterator that returns `Some(Decimal128)` or `None`, that can be used on
a
/// [`Decimal128Array`]
-pub type Decimal128Iter<'a> = BasicDecimalIter<'a, 16>;
+pub type Decimal128Iter<'a> = DecimalIter<'a, Decimal128Type>;
/// an iterator that returns `Some(Decimal256)` or `None`, that can be used on
a
/// [`super::Decimal256Array`]
-pub type Decimal256Iter<'a> = BasicDecimalIter<'a, 32>;
-/// an iterator that returns `Some(i128)` or `None`, that can be used on a
-/// [`Decimal128Array`]
-#[derive(Debug)]
-#[deprecated(note = "Please use `Decimal128Iter` instead. \
- `DecimalIter` iterates `Decimal128` values as i128 values. \
- This is kept mostly for back-compatibility purpose. Suggests to use
`Decimal128Array.iter()` \
- that returns `Decimal128Iter`.")]
-pub struct DecimalIter<'a> {
Review Comment:
I wanted to reuse this name, as `BasicDecimal` is confusing. It isn't vital
we remove it, but I think it is better to not be stuck on a stale name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
