tustvold commented on PR #2477: URL: https://github.com/apache/arrow-rs/pull/2477#issuecomment-1218007353
> we have to implement some part of Decimal128 and Decimal256 separately Perhaps, although the lower you push the differences the more code can be shared. To ground this concretely in what this PR does, the validation logic could be placed on DecimalNativeType, with everything else generic. Or to put it another way, this PR doesn't lose any flexibility over using const generics, but is simpler and more easily extensible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
