tustvold commented on code in PR #2482:
URL: https://github.com/apache/arrow-rs/pull/2482#discussion_r948027289
##########
parquet/src/bin/parquet-read.rs:
##########
@@ -66,10 +67,20 @@ fn main() {
let num_records = args.num_records;
let json = args.json;
- let path = Path::new(&filename);
- let file = File::open(&path).expect("Unable to open file");
- let parquet_reader =
- SerializedFileReader::new(file).expect("Failed to create reader");
+ let parquet_reader: Box<dyn FileReader> = if filename == "-" {
+ let mut buf = Vec::new();
Review Comment:
It may surprise people who aren't familiar with parquet that this will
buffer the entire file in memory, as opposed to streaming it. Perhaps we could
add a note to the help text to alert people?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
