alamb commented on code in PR #2482:
URL: https://github.com/apache/arrow-rs/pull/2482#discussion_r948139012
##########
parquet/src/bin/parquet-read.rs:
##########
@@ -66,10 +67,20 @@ fn main() {
let num_records = args.num_records;
let json = args.json;
- let path = Path::new(&filename);
- let file = File::open(&path).expect("Unable to open file");
- let parquet_reader =
- SerializedFileReader::new(file).expect("Failed to create reader");
+ let parquet_reader: Box<dyn FileReader> = if filename == "-" {
+ let mut buf = Vec::new();
Review Comment:
As @tustvold suggests, I think it is inevitable that reading from stdin
requires buffering (because the parquet footer is at the end of the file and we
need to get past all the data to get to the footer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
