liukun4515 commented on code in PR #3185:
URL: https://github.com/apache/arrow-datafusion/pull/3185#discussion_r948787666
##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -271,8 +271,8 @@ async fn csv_explain_plans() {
let expected = vec![
"Explain [plan_type:Utf8, plan:Utf8]",
" Projection: #aggregate_test_100.c1 [c1:Utf8]",
- " Filter: #aggregate_test_100.c2 > Int64(10) [c1:Utf8, c2:Int32]",
- " TableScan: aggregate_test_100 projection=[c1, c2],
partial_filters=[#aggregate_test_100.c2 > Int64(10)] [c1:Utf8, c2:Int32]",
+ " Filter: #aggregate_test_100.c2 > Int32(10) [c1:Utf8, c2:Int32]",
Review Comment:
after optimized, the INT64(10) will be cast to `INT32(10), because of the
left type is INT32
##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -271,8 +271,8 @@ async fn csv_explain_plans() {
let expected = vec![
"Explain [plan_type:Utf8, plan:Utf8]",
" Projection: #aggregate_test_100.c1 [c1:Utf8]",
- " Filter: #aggregate_test_100.c2 > Int64(10) [c1:Utf8, c2:Int32]",
- " TableScan: aggregate_test_100 projection=[c1, c2],
partial_filters=[#aggregate_test_100.c2 > Int64(10)] [c1:Utf8, c2:Int32]",
+ " Filter: #aggregate_test_100.c2 > Int32(10) [c1:Utf8, c2:Int32]",
Review Comment:
after optimization, the INT64(10) will be cast to `INT32(10), because of the
left type is INT32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
