mingmwang commented on code in PR #151:
URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949743190


##########
ballista/rust/executor/src/execution_loop.rs:
##########
@@ -108,7 +107,7 @@ pub async fn poll_loop<T: 'static + AsLogicalPlan, U: 
'static + AsExecutionPlan>
                 }
             }
             Err(error) => {
-                warn!("Executor registration failed. If this continues to 
happen the executor might be marked as dead by the scheduler. Error: {}", 
error);
+                warn!("Executor poll work loop failed. If this continues to 
happen the Scheduler might be marked as dead. Error: {}", error);

Review Comment:
   If I understand correctly, currently in the Scheduler side, there is no 
logic to mark an Executor dead or blacklist an Executor. And I think in a 
distributed system, if a remote RPC call failed,  callers usually suspect that 
the other part might has a problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to