mingmwang commented on code in PR #151:
URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949759864
##########
ballista/rust/executor/src/executor_server.rs:
##########
@@ -368,16 +425,31 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> TaskRunnerPool<T,
//2. loop for task fetching and running
let executor_server = self.executor_server.clone();
+ let mut task_runner_shutdown = graceful.subscribe_for_shutdown();
+ // Not used directly.
+ let task_runner_complete = graceful.shutdown_complete_tx.clone();
tokio::spawn(async move {
info!("Starting the task runner pool");
+
+ // Drop and notifies the receiver half that the shutdown is
complete
Review Comment:
I will take @avantgardnerio suggestion and call the drop explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
