roeap commented on PR #2509: URL: https://github.com/apache/arrow-rs/pull/2509#issuecomment-1220532119
After chasing a bug with signing via access key for a while, implementation was quite straight forward, and I could lean on most of the logic from the AWS implementation. Generally authorization needs to be cleaned up. Aside from getting rid of the OAuth crate, we have some fallible operations in the `with_azure_authorization` function, but I think we can be fairly confident or validate on build as to "unwrap" those? Also I tried to activate the `stream_get` tests also for Azure and there are some bugs to be fixed, that should be doable. Implementations of the `ObjectStore` trait are very similar for azure and aws, main difference being if-not-exists support, Thought about if these two should share code, but maybe that's better for a follow up? > I'd be happy to help out with that if you like? So far I only worked with OAuth via higher level APIs, so help is highly welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
