roeap commented on code in PR #2509:
URL: https://github.com/apache/arrow-rs/pull/2509#discussion_r950808326
##########
object_store/src/client/oauth.rs:
##########
@@ -219,3 +223,82 @@ fn b64_encode_obj<T: serde::Serialize>(obj: &T) ->
Result<String> {
let string = serde_json::to_string(obj).context(EncodeSnafu)?;
Ok(base64::encode_config(string, base64::URL_SAFE_NO_PAD))
}
+
Review Comment:
Do we need different features for aws, gcp, and azure when the last sdk is
gone? I guess the size of the compiled binary can be reduced a bit and maybe a
dependency saved, but would that be a "siginificant" saving?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
