tustvold commented on code in PR #2529:
URL: https://github.com/apache/arrow-rs/pull/2529#discussion_r950332551
##########
parquet/src/data_type.rs:
##########
@@ -1235,7 +1241,7 @@ impl FromBytes for ByteArray {
}
impl FromBytes for FixedLenByteArray {
- type Buffer = [u8; 8];
+ type Buffer = Vec<u8>;
fn from_le_bytes(bs: Self::Buffer) -> Self {
Self(ByteArray::from(bs.to_vec()))
Review Comment:
This is performing an unnecessary clone now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
