liukun4515 commented on code in PR #2529:
URL: https://github.com/apache/arrow-rs/pull/2529#discussion_r950344083
##########
parquet/benches/arrow_reader.rs:
##########
@@ -354,6 +431,59 @@ fn create_primitive_array_reader(
}
}
+fn create_decimal_byte_array_reader(
+ page_iterator: impl PageIterator + 'static,
+ column_desc: ColumnDescPtr,
+) -> Box<dyn ArrayReader> {
+ let data_type = parquet_to_arrow_field(column_desc.as_ref())
+ .unwrap()
+ .data_type()
+ .clone();
+
+ let physical_type = column_desc.physical_type();
+
+ match physical_type {
+ Type::BYTE_ARRAY => {
+ match data_type {
+ DataType::Decimal128(precision, scale) => {
+ // read decimal data from parquet binary physical type
+ let convert = DecimalByteArrayConvert::new(
Review Comment:
thanks for your remind, after #2528 merged, and refactor this pr and review
it.
When the #2425 can be reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
