liukun4515 commented on PR #3185: URL: https://github.com/apache/arrow-datafusion/pull/3185#issuecomment-1223447344
> @liukun4515 I will start reviewing this PR today. I am also adding a type coercion rule in #3101 and I plan on adding others. > > Do you think it makes sense to have one type coercion rule or multiple? It might be more efficient to have one rule that can handle all the cases? I go through your https://github.com/apache/arrow-datafusion/pull/3101, which add an optimizer rule to do the type coercion. I feels a little wired about the implementation, but I think it works and can migrate the type coercion from physical phase to logical phase. I want to investigate other system and find out where to do the type coercion for the input expr. @andygrove @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
